Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for TryFrom<&Value> for Decimal #1139

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Add unit tests for TryFrom<&Value> for Decimal #1139

merged 2 commits into from
Apr 7, 2023

Conversation

ChobobDev
Copy link
Contributor

This resolves #1138

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4634481842

  • 53 of 53 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 98.81%
Files with Coverage Reduction New Missed Lines %
core/src/executor/sort.rs 4 96.75%
Totals Coverage Status
Change from base Build 4630446266: 0.01%
Covered Lines: 42424
Relevant Lines: 42935
💛 - Coveralls

@ChobobDev
Copy link
Contributor Author

I think I am ready for a review

@ChobobDev ChobobDev marked this pull request as ready for review April 7, 2023 01:24
@panarch panarch self-requested a review April 7, 2023 08:51
@panarch panarch added the improvement Improvements for existing features label Apr 7, 2023
@panarch panarch changed the title add omitted try_into_decimal() Add unit tests for TryFrom<&Value> for Decimal Apr 7, 2023
panarch
panarch approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Thanks a lot 👍

@panarch panarch merged commit 0681a1a into gluesql:main Apr 7, 2023
8 checks passed
@ChobobDev ChobobDev deleted the test/try_into_Decimal branch April 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@ChobobDev ChobobDev

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing fn try_into_decimal() in value/convert.rs
3 participants
@ChobobDev @coveralls @panarch