-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DESCRIBE statement #1169
base: main
Are you sure you want to change the base?
Add DESCRIBE statement #1169
Conversation
Auto-increment is not yet implemented in GlueSQL, but I have included the extra column for it. |
pkg/javascript/web/src/payload.rs
Outdated
Payload::ExplainTable(columns) => { | ||
let columns = columns | ||
.into_iter() | ||
.map(|(field, data_type, nullable, key, default, extra)| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't have any fields to show on extra
.
Looks like it would be better to remove extra
.
core/src/executor/execute.rs
Outdated
.await? | ||
.ok_or_else(|| ExecuteError::TableNotFound(table_name.to_owned()))?; | ||
|
||
let output: Vec<(String, DataType, bool, String, String, String)> = column_defs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to wrap verbose tuple with struct like..
struct ExplainTableRow {
name: String,
data_type: DataType,
nullable: bool,
key: String,
default: String,
}
@devgony , I applied your reviews |
Thank you for quick commit. |
Please, can you check the |
Pull Request Test Coverage Report for Build 6310736809
💛 - Coveralls |
hi @panarch |
resolve #1113