Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable, key, default to GLUE_TABLE_COLUMNS #1177

Merged
merged 3 commits into from
May 6, 2023

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented May 6, 2023

Goal

gluesql> CREATE TABLE T1 (id INT PRIMARY KEY, name TEXT NULL);
Table created

gluesql> CREATE TABLE T2 (id INT UNIQUE DEFAULT 0 NULL);
Table created

gluesql> SELECT * FROM GLUE_TABLE_COLUMNS;

gluesql> SELECT * FROM GLUE_TABLE_COLUMNS;

TABLE_NAME COLUMN_NAME COLUMN_ID NULLABLE KEY DEFAULT
T1 id 1 FALSE PRIMARY KEY
T1 name 2 TRUE
T2 id 1 TRUE UNIQUE 0

Todo

  • add nullable, key, default to GLUE_TABLE_COLUMNS

@devgony devgony added the enhancement New feature or request label May 6, 2023
@devgony devgony requested review from panarch and ever0de May 6, 2023 07:23
@devgony devgony self-assigned this May 6, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4900727223

  • 26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 98.986%

Files with Coverage Reduction New Missed Lines %
core/src/executor/fetch.rs 13 97.06%
Totals Coverage Status
Change from base Build 4900246167: 0.03%
Covered Lines: 44333
Relevant Lines: 44787

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice!
Thanks a lot 👍

@panarch panarch added improvement Improvements for existing features and removed enhancement New feature or request labels May 6, 2023
@panarch panarch merged commit d560758 into gluesql:main May 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants