Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to bundle all errors using error module, #1178

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

panarch
Copy link
Member

@panarch panarch commented May 6, 2023

  • Bundle and export all errors using error module.
  • Rename result module to "error" for out-of-core-workspace users.
  • Update storages/ and test-suite/ codes to use global error module.

@panarch panarch added the improvement Improvements for existing features label May 6, 2023
@panarch panarch requested review from ever0de and devgony May 6, 2023 08:25
@panarch panarch self-assigned this May 6, 2023
@coveralls
Copy link

coveralls commented May 6, 2023

Pull Request Test Coverage Report for Build 4900718228

  • 10 of 10 (100.0%) changed or added relevant lines in 6 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 98.955%

Files with Coverage Reduction New Missed Lines %
core/src/executor/fetch.rs 13 96.95%
Totals Coverage Status
Change from base Build 4900246167: -0.005%
Covered Lines: 43643
Relevant Lines: 44104

💛 - Coveralls

Bundle and export all errors using error module.
Rename result module to "error" for out-of-core-workspace users.
Update storages/ and test-suite/ codes to use global error module.
@panarch panarch merged commit a9078f7 into main May 6, 2023
9 checks passed
@panarch panarch deleted the bundle-errors branch May 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants