Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rounding test cases for ast_builder #1186

Merged
merged 4 commits into from
May 13, 2023
Merged

Add rounding test cases for ast_builder #1186

merged 4 commits into from
May 13, 2023

Conversation

LEE026
Copy link
Contributor

@LEE026 LEE026 commented May 13, 2023

No description provided.

@panarch panarch requested review from devgony and panarch May 13, 2023 10:24
@panarch panarch added the improvement Improvements for existing features label May 13, 2023
@coveralls
Copy link

coveralls commented May 13, 2023 •
edited

Pull Request Test Coverage Report for Build 4966630619

  • 61 of 66 (92.42%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 98.932%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/function/math/rounding.rs 61 66 92.42%
Files with Coverage Reduction New Missed Lines %
core/src/executor/validate.rs 1 99.24%
Totals Coverage Status
Change from base Build 4965667946: -0.04%
Covered Lines: 43245
Relevant Lines: 43712
💛 - Coveralls

panarch
panarch approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot 👍 👍

@panarch panarch merged commit 7d608fa into gluesql:main May 13, 2023
9 checks passed
sooyeonyim-t pushed a commit to sooyeonyim-t/gluesql that referenced this pull request May 14, 2023
@LEE026 @sooyeonyim-t
Add rounding test cases for ast_builder - round, ceil, floor (gluesql…
dbd57c7 
…#1186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@LEE026 LEE026

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LEE026 @coveralls @panarch