Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test code function / text / trimming #1190

Merged
merged 13 commits into from
May 14, 2023
Merged

Add test code function / text / trimming #1190

merged 13 commits into from
May 14, 2023

Conversation

Bangseungjae
Copy link
Contributor

Todo

  • add ltrim test code
  • add rtrim test code

@devgony devgony requested review from panarch and devgony May 13, 2023 12:05
@devgony devgony added the improvement Improvements for existing features label May 13, 2023
@coveralls
Copy link

coveralls commented May 13, 2023 •
edited

Pull Request Test Coverage Report for Build 4969363283

  • 87 of 92 (94.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 98.893%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/function/text/trimming.rs 87 92 94.57%
Totals Coverage Status
Change from base Build 4967019043: -0.009%
Covered Lines: 43515
Relevant Lines: 44002
💛 - Coveralls

panarch
panarch approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot 👍 👍

@panarch panarch merged commit c7581e6 into gluesql:main May 14, 2023
9 checks passed
sooyeonyim-t pushed a commit to sooyeonyim-t/gluesql that referenced this pull request May 14, 2023
@Bangseungjae @sooyeonyim-t
Add ast builder docs of ltrim and rtrim functions (gluesql#1190)
8e890e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@Bangseungjae Bangseungjae

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bangseungjae @coveralls @panarch @devgony