Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Position and Indexing test code #1203

Merged
merged 18 commits into from
May 14, 2023
Merged

Add Position and Indexing test code #1203

merged 18 commits into from
May 14, 2023

Conversation

Bangseungjae
Copy link
Contributor

Todo


add test suite

  • add find_idx test code
  • add position test code
  • add left test code
  • add right test code

@Bangseungjae
test: Write test code ltrim and rtrim function
9c92dd4 
- testing rtrim
- testing ltrim
@Bangseungjae
:test: add trimming test code
d4ae0d3
@Bangseungjae
test: write test code ltrim and rtrim function
7d7c805 
- testing ltrim function
- testing rtrim function
@Bangseungjae
test: add trimming
69c04ea
@Bangseungjae
Merge branch 'main' of https://github.com/Bangseungjae/gluesql
fcf19f5
@Bangseungjae
fix: git conflict
ce238e1
@Bangseungjae
improvement: cargo fmt
a9ab4b9
@Bangseungjae
fix: cargo fmt
e45d365
@Bangseungjae
Merge branch 'main' of https://github.com/Bangseungjae/gluesql
4b2a289
@Bangseungjae
Merge branch 'test/v2/trimming'
d7fd321
@Bangseungjae
fix: git conflict
58b8f94
@Bangseungjae
fix: cargo fmt
4b0dd94
@Bangseungjae
Merge branch 'main' of https://github.com/Bangseungjae/gluesql into t…
dd1fd77 
…est/v2/trimming
@Bangseungjae
docs: add trimming docs
4dfda27
@Bangseungjae
Merge branch 'main' of https://github.com/Bangseungjae/gluesql into d…
3dc55cb 
…ocs/trimming
@Bangseungjae
test: add position and indexing suite test code
a437f6a
@Bangseungjae
Merge branch 'main' of https://github.com/Bangseungjae/gluesql into t…
ed22d42 
…est/position_and_indexing
@Bangseungjae
fix: cargo fmt
8a4d430
@panarch panarch requested review from panarch and devgony May 14, 2023 03:55
@panarch panarch added the improvement Improvements for existing features label May 14, 2023
panarch
panarch approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice 👍 Thanks a lot!

@panarch panarch merged commit 752cc0b into gluesql:main May 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@Bangseungjae Bangseungjae

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bangseungjae @panarch