Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime current date and time test case for ast builder #1205

Conversation

heewoneha
Copy link
Contributor

Goal

  • Add datetime current date and time test case for ast builder

Todo

  • Add datetime current date and time test case for ast builder (now())

@panarch panarch requested review from panarch and devgony May 14, 2023 04:20
@panarch panarch added the improvement Improvements for existing features label May 14, 2023
@coveralls
Copy link

coveralls commented May 14, 2023

Pull Request Test Coverage Report for Build 4970513611

  • 37 of 40 (92.5%) changed or added relevant lines in 1 file are covered.
  • 55 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 98.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/function/datetime/current_date_and_time.rs 37 40 92.5%
Files with Coverage Reduction New Missed Lines %
core/src/executor/execute.rs 21 91.86%
core/src/executor/aggregate/mod.rs 34 82.47%
Totals Coverage Status
Change from base Build 4970467284: -0.2%
Covered Lines: 43919
Relevant Lines: 44475

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice 👍 👍 Thanks a lot!

@panarch panarch merged commit e0522a1 into gluesql:main May 14, 2023
9 checks passed
@heewoneha heewoneha deleted the ast_builder_function_datetime_current_date_and_time branch May 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants