Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve example codes formatting #1235

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Improve example codes formatting #1235

merged 1 commit into from
Jun 5, 2023

Conversation

jopemachine
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5166748443

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.825%
Totals Coverage Status
Change from base Build 5129667088: 0.0%
Covered Lines: 44061
Relevant Lines: 44585
💛 - Coveralls

@panarch
Copy link
Member

panarch commented Jun 5, 2023

It loooks good enough to be reviewed. is there any other work planned to do? currently this pr is marked as draft

@jopemachine jopemachine marked this pull request as ready for review June 5, 2023 06:19
@jopemachine
Copy link
Contributor Author

It loooks good enough to be reviewed. is there any other work planned to do? currently this pr is marked as draft

Thanks for your review, I don't think there are other works to consider. so, I just made the PR ready.

panarch
panarch approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@panarch panarch merged commit 314c551 into gluesql:main Jun 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

@devgony devgony Awaiting requested review from devgony

Assignees

@jopemachine jopemachine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jopemachine @coveralls @panarch