fix: allow interval cast-related functions to accept only literals instead of evaluations #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ever0de
force-pushed
the
fix/do-not-allow-cast-of-value-to-interval
branch
from
f7147ae
to
eb96e7f
Compare
Pull Request Test Coverage Report for Build 5177060014
💛 - Coveralls |
ever0de
force-pushed
the
fix/do-not-allow-cast-of-value-to-interval
branch
4 times, most recently
from
9abbbcf
to
196b74b
Compare
ever0de
changed the title
Value to Interval,
panarch
reviewed
Jun 5, 2023
| @@ -173,7 +172,7 @@ impl JsonStorage { | |||
|
|
|||
| let value = match value.get_type() { | |||
| Some(data_type) if data_type != column_def.data_type => { | |||
| block_on(value.cast(&column_def.data_type))? | |||
| value.cast(&column_def.data_type)? | |||
There was a problem hiding this comment.
here was the only case which async_io was used in json-storage.
may be we can remove async_io in json storage Cargo.toml
panarch
reviewed
Jun 5, 2023
core/src/data/interval/string.rs
Outdated
| .await | ||
| .and_then(Value::try_from) | ||
| .map(String::from)?; | ||
| let literal = match &*expr { |
There was a problem hiding this comment.
rather than &*expr, expr.as_ref() would be simple.
- remote async [Value::try_cast_from_literal, Interval::parse] - remove `DataType::Interval` cast to Value - remove `Value::try_into_interval` - Rename `From<&Interval> for String` to `to_sql_str`
ever0de
force-pushed
the
fix/do-not-allow-cast-of-value-to-interval
branch
from
60e8eb3
to
6709f06
Compare
panarch
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataType::Intervalcast to ValueValue::try_into_intervalFrom<&Interval> for Stringtoto_sql_str