Remove sync methods in core/ Glue struct,

[panarch]

Update Glue struct to provide async methods only.
Apply the changes to existing codes (mainly test codes)

[coveralls]

Pull Request Test Coverage Report for Build 5228954120

• 160 of 194 (82.47%) changed or added relevant lines in 18 files are covered.
• 51 unchanged lines in 6 files lost coverage.
• Overall coverage decreased (-0.1%) to 98.734%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
storages/shared-memory-storage/tests/concurrent_access.rs	6	7	85.71%
pkg/rust/tests/glue.rs	7	9	77.78%
storages/json-storage/tests/schema.rs	11	13	84.62%
storages/memory-storage/tests/memory_storage.rs	12	14	85.71%
storages/shared-memory-storage/tests/shared_memory_storage.rs	15	17	88.24%
storages/json-storage/tests/primary_key.rs	6	9	66.67%
storages/composite-storage/tests/error.rs	17	21	80.95%
storages/json-storage/tests/json_dml.rs	14	18	77.78%
storages/sled-storage/tests/export_and_import.rs	15	19	78.95%
storages/composite-storage/tests/basic.rs	13	18	72.22%

Files with Coverage Reduction	New Missed Lines	%
core/src/ast/function.rs	1	99.88%
core/src/executor/validate.rs	1	99.24%
core/src/plan/expr/function.rs	1	99.56%
storages/sled-storage/tests/sled_transaction.rs	4	96.13%
core/src/executor/evaluate/function.rs	10	97.6%
core/src/executor/aggregate/mod.rs	34	82.47%

Totals
Change from base Build 5221131260:	-0.1%
Covered Lines:	45640
Relevant Lines:	46225

---

💛 - Coveralls

[serprex]

@panarch I created a PR to update pgwire examples to use latest gluesql, but I found that calling .await on result of execute continued to fail even after moving to storing glue in tokio::sync::Mutex. I even tried getting around having a mutex at all using channels: https://github.com/serprex/pgwire/tree/fix1 to no avail

Are you aware of gluesql having compatibility issues with tokio?

[ever0de]

@panarch I created a PR to update pgwire examples to use latest gluesql, but I found that calling .await on result of execute continued to fail even after moving to storing glue in tokio::sync::Mutex. I even tried getting around having a mutex at all using channels: serprex/pgwire@fix1 to no avail

Are you aware of gluesql having compatibility issues with tokio?

hello :)
I've checked the pgwire code, and it appears that the SimpleQueryHandler requires the Send + Sync supertraits.

I think it's due to the failure to implement Send and Sync in gluesql::{GStore, GStoreMut}.

• Related issue: Send, Sync supertrait support for GStore, GStoreMut #1265
• https://docs.rs/async-trait/latest/async_trait/#non-threadsafe-futures

You can check by simply implementing the following async_trait.

pub struct GluesqlProcessor {
    db: SharedMemoryStorage,
}

#[async_trait(?Send)]
trait SendTest {
    async fn query(&self, query: &str);
}

#[async_trait(?Send)] // success, but `#[async_trait]` fails.
impl SendTest for GluesqlProcessor {
    async fn query(&self, query: &str) {
        let db = self.db.clone();
        let mut glue = Glue::new(db.clone());

        let result = glue.execute(query).await;
        println!("{:?}", result);
    }
}

We are working on some ideas to address this issue, but have not yet completed a functional implementation of gluesql that supports the Optional Send combination of async_trait.

Would appreciate your understanding on this point 😢