Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement ast_builder for replace function #1275

Merged
merged 1 commit into from Jul 14, 2023
Merged

feat: implement ast_builder for replace function #1275

merged 1 commit into from Jul 14, 2023

Conversation

ChobobDev
Copy link
Contributor

resolves #1274

@ChobobDev ChobobDev marked this pull request as ready for review July 12, 2023 15:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5533106025

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.709%
Totals Coverage Status
Change from base Build 5530864883: -0.005%
Covered Lines: 44105
Relevant Lines: 44682
💛 - Coveralls

@ChobobDev
Copy link
Contributor Author

I think I am ready for the review

@panarch panarch added the enhancement New feature or request label Jul 14, 2023
panarch
panarch approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Thanks for the contribution 👍

@panarch panarch merged commit 35c64bd into gluesql:main Jul 14, 2023
11 checks passed
@ChobobDev ChobobDev deleted the ast_builder/replace branch July 15, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

@devgony devgony Awaiting requested review from devgony

Assignees

@ChobobDev ChobobDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ast_builder for replace function
3 participants
@ChobobDev @coveralls @panarch