Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: impl bitwise-and operation #1281

Merged
merged 13 commits into from Jul 22, 2023
Merged

Feat: impl bitwise-and operation #1281

merged 13 commits into from Jul 22, 2023

Conversation

jinlee0
Copy link
Contributor

@jinlee0 jinlee0 commented Jul 13, 2023

resolve #1277

@ever0de ever0de added the enhancement New feature or request label Jul 13, 2023
@coveralls
Copy link

coveralls commented Jul 13, 2023 •
edited

Pull Request Test Coverage Report for Build 5629782052

  • 271 of 281 (96.44%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.679%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/bitwise_and.rs 62 72 86.11%
Totals Coverage Status
Change from base Build 5629710089: 0.05%
Covered Lines: 45783
Relevant Lines: 46396
💛 - Coveralls

ever0de
ever0de requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the comments in coveralls and write additional unit tests (or integration tests) for the uncovered lines.
#1281 (comment)

core/src/data/literal.rs Outdated Show resolved Hide resolved
core/src/data/literal.rs Outdated Show resolved Hide resolved
core/src/data/literal.rs Outdated Show resolved Hide resolved
test-suite/src/bitwise_and.rs Show resolved Hide resolved
test-suite/src/bitwise_and.rs Outdated Show resolved Hide resolved
@ever0de ever0de self-requested a review July 16, 2023 11:43
@panarch panarch mentioned this pull request Jul 17, 2023
Merged
devgony
devgony reviewed Jul 17, 2023
View reviewed changes
test-suite/src/bitwise_and.rs Show resolved Hide resolved
core/src/executor/evaluate/evaluated.rs Outdated Show resolved Hide resolved
core/src/data/value/mod.rs Show resolved Hide resolved
@jinlee0 jinlee0 requested a review from devgony July 17, 2023 16:41
panarch
panarch reviewed Jul 22, 2023
View reviewed changes
core/src/data/value/mod.rs Outdated Show resolved Hide resolved
panarch
panarch reviewed Jul 22, 2023
View reviewed changes
core/src/data/literal.rs Outdated Show resolved Hide resolved
@jinlee0
Copy link
Contributor Author

jinlee0 commented Jul 22, 2023

@panarch
I think it is done!

@panarch panarch self-requested a review July 22, 2023 08:31
panarch
panarch approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice!! Thanks a lot for the contribution 👍 👍
Once the conflict resolved, then let's ship this to the main

@panarch panarch merged commit 94d4b77 into gluesql:main Jul 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@jinlee0 jinlee0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "&" SQL operator
5 participants
@jinlee0 @coveralls @panarch @ever0de @devgony