Feature/operator bit not #1321
Merged
Feature/operator bit not #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5658019652
💛 - Coveralls |
|
I am going to add some more tests to increase coverage. |
ever0de
reviewed
Jul 22, 2023
Comment on lines
259
to
313
| Evaluated::StrSlice { source, range } => { | ||
| Err(EvaluateError::UnsupportedUnaryBitNot(source[range.clone()].to_owned()).into()) | ||
| } |
There was a problem hiding this comment.
Can we also add test code for this case?
https://coveralls.io/builds/61510412/source?filename=core%2Fsrc%2Fexecutor%2Fevaluate%2Fevaluated.rs#L259
There was a problem hiding this comment.
Let me try.
Thank you for the review.
There was a problem hiding this comment.
I pushed a new patch to test EvaluateError::UnsupportedUnaryBitNot error.
This patch adds some test cases for the bitwise-not operator ~.
gurugio
force-pushed
the
feature/operator_bit_not
branch
from
6bd1acd
to
c206b1c
Compare
added 3 commits
July 23, 2023 22:47
This patch implements ~ operator - Add translation from SqlUnaryOperator::PGBitwiseNot to ast::UnaryOerator::BitNot - add ast::UnaryOperator::BitNot to ToSql implementation for UnaryOperator - Add evaluation of UnaryOperator::BitNot into Value enum - Add implementation of ~ operator in Value enum
This patch adds more tests to increase test coverage.
One more test to increase test coverage
gurugio
force-pushed
the
feature/operator_bit_not
branch
from
c206b1c
to
eea4753
Compare
|
I will add a test case to cover Null data. |
The test missed ~ operator.
panarch
reviewed
Jul 24, 2023
core/src/ast/operator.rs
Outdated
| @@ -18,6 +19,7 @@ impl ToSql for UnaryOperator { | |||
| UnaryOperator::Minus => "-".to_owned(), | |||
| UnaryOperator::Not => "NOT ".to_owned(), | |||
| UnaryOperator::Factorial => "!".to_owned(), | |||
| &UnaryOperator::BitNot => "~".to_owned(), | |||
There was a problem hiding this comment.
&is unnecessary. we can remove this.- could we use
Bitwiseprefix rather thanBitbecause we already usebitwisefor other operators. e.g.BinaryOperator::BitwiseAndandBinaryOperator::BitwiseShiftLeft
There was a problem hiding this comment.
- Ok. It's my mistake.
- Ok. I will change it to BitwiseNot.
There are already other bitwise operators, for instance bitwise_and and bitwise_shift_left.
|
Hi, Now I think it's ready to be merged. |
panarch
reviewed
Jul 25, 2023
core/src/executor/evaluate/expr.rs
Outdated
| @@ -66,6 +66,7 @@ pub fn unary_op<'a>(op: &UnaryOperator, v: Evaluated<'a>) -> Result<Evaluated<'a | |||
| UnaryOperator::Minus => v.unary_minus(), | |||
| UnaryOperator::Not => v.try_into().map(|v: bool| Evaluated::from(Value::Bool(!v))), | |||
| UnaryOperator::Factorial => v.unary_factorial(), | |||
| &UnaryOperator::BitwiseNot => v.unary_bitwise_not(), | |||
panarch
reviewed
Jul 25, 2023
core/src/translate/operator.rs
Outdated
| @@ -13,6 +13,7 @@ pub fn translate_unary_operator(sql_unary_operator: &SqlUnaryOperator) -> Result | |||
| SqlUnaryOperator::Minus => Ok(UnaryOperator::Minus), | |||
| SqlUnaryOperator::Not => Ok(UnaryOperator::Not), | |||
| SqlUnaryOperator::PGPostfixFactorial => Ok(UnaryOperator::Factorial), | |||
| &SqlUnaryOperator::PGBitwiseNot => Ok(UnaryOperator::BitwiseNot), | |||
gurugio
force-pushed
the
feature/operator_bit_not
branch
from
34b5bd4
to
5c53141
Compare
gurugio
force-pushed
the
feature/operator_bit_not
branch
from
02fd855
to
a8983b5
Compare
|
Hi,
|
panarch
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, I pushed a implementation for bot of
BIT_NOTfunction and ~ operator.As review comment, I removed implementation of
BIT_NOTfunction and pushed only ~ operator in this PR.Please review.
I will add more test cases if the coverage test result is not good enough.