Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LAST_DAY function #1315 #1323

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Implement LAST_DAY function #1315 #1323

merged 10 commits into from
Jul 28, 2023

Conversation

cjy13753
Copy link
Contributor

resolve #1295

@ever0de ever0de added the enhancement New feature or request label Jul 22, 2023
@coveralls
Copy link

coveralls commented Jul 22, 2023 •
edited

Pull Request Test Coverage Report for Build 5686842171

  • 68 of 73 (93.15%) changed or added relevant lines in 5 files are covered.
  • 24 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 98.616%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/function/last_day.rs 44 49 89.8%
Files with Coverage Reduction New Missed Lines %
core/src/data/interval/mod.rs 1 99.49%
core/src/translate/query.rs 2 98.94%
core/src/executor/execute.rs 21 91.86%
Totals Coverage Status
Change from base Build 5680441073: -0.05%
Covered Lines: 46106
Relevant Lines: 46753
💛 - Coveralls

@panarch panarch self-requested a review July 27, 2023 12:16
panarch
panarch approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all great! Thanks a lot for the contribution 👍 👍

@panarch panarch merged commit a624028 into gluesql:main Jul 28, 2023
9 checks passed
@cjy13753
Copy link
Contributor Author

This is my first ever PR to an open source project. Appreciate your help and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@cjy13753 cjy13753

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement LAST_DAY function
4 participants
@cjy13753 @coveralls @panarch @ever0de