Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement take function in ast_builder #1346

Merged
merged 13 commits into from Jul 29, 2023
Merged

feat: Implement take function in ast_builder #1346

merged 13 commits into from Jul 29, 2023

Conversation

ding-co
Copy link
Contributor

@ding-co ding-co commented Jul 29, 2023

resolves #1345

@panarch panarch added the enhancement New feature or request label Jul 29, 2023
@coveralls
Copy link

coveralls commented Jul 29, 2023 •
edited

Pull Request Test Coverage Report for Build 5699093949

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • 32 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 98.594%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 32 83.51%
Totals Coverage Status
Change from base Build 5699069571: 0.02%
Covered Lines: 46211
Relevant Lines: 46870
💛 - Coveralls

panarch
panarch approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks a lot 👍

@panarch panarch merged commit 4cbe8a4 into gluesql:main Jul 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@ding-co ding-co

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ast_builder for take function
3 participants
@ding-co @coveralls @panarch