Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Value::evaluate_cmp_with_literal between Decimal and Literal::Num… #1352

Merged
merged 1 commit into from Aug 4, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Jul 30, 2023

…ber,

Handle Value::Decimal & Literal::Number branch - convert value to bigdecimal and run cmp.
Rewrite test-suite/ data-type/decimal tests, add a comparison test case.

e.g.

CREATE TABLE Foo (v DECIMAL);
INSERT INTO Foo VALUES (1), (2);

SELECT v FROM Foo WHERE v > 0;

WHERE v > 0 was not working.

…ber,

Handle Value::Decimal & Literal::Number branch - convert value to bigdecimal and run cmp.
Rewrite test-suite/ data-type/decimal tests, add a comparison test case.
@panarch panarch added the bug Something isn't working label Jul 30, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5704628120

  • 44 of 44 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.56%

Totals Coverage Status
Change from base Build 5704033435: 0.007%
Covered Lines: 46206
Relevant Lines: 46881

💛 - Coveralls

@panarch panarch merged commit 1f4c673 into main Aug 4, 2023
10 checks passed
@panarch panarch deleted the fix-value-evaluate-cmp-with-decimal-literal branch August 4, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants