Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Python Binding #1357

Merged
merged 43 commits into from Oct 3, 2023

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Jul 31, 2023

Related issue: #480.

This PR implements Python bindings for the following storages:

  • MemoryStorage
  • JsonStorage
  • SharedMemoryStorage
  • SledStorage

I think GlueSQL in Python will be a powerful tool.

Future improvements:

  • Convert the query function to an asynchronous function.
  • Optimize the convert_payload function for better performance.
  • Add bindings for the Composite Storage.

@panarch panarch added the enhancement New feature or request label Jul 31, 2023
@coveralls
Copy link

coveralls commented Jul 31, 2023

Pull Request Test Coverage Report for Build 6390864564

  • 0 of 233 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 98.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/python/src/error.rs 0 15 0.0%
pkg/python/src/lib.rs 0 43 0.0%
pkg/python/src/storages.rs 0 68 0.0%
pkg/python/src/payload.rs 0 107 0.0%
Totals Coverage Status
Change from base Build 6390665568: -0.5%
Covered Lines: 50237
Relevant Lines: 50913

💛 - Coveralls

pkg/python/Cargo.toml Outdated Show resolved Hide resolved
@jopemachine jopemachine marked this pull request as ready for review August 27, 2023 04:55
@panarch panarch self-requested a review September 9, 2023 07:20
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks all great!
just before merging it, could you add a github action for python build?
we need a way to verify that other future changes not to break the python build.

@panarch panarch self-requested a review October 3, 2023 12:06
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so pleasure to see the new meaningful functionality.
Everything looks great!! Let's ship this to the main 👍 👍 👍

@panarch panarch merged commit 1f519b5 into gluesql:main Oct 3, 2023
10 checks passed
@jopemachine jopemachine changed the title feat: Implement python binding feat: Implement Python Binding Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants