Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SPLICE function #1371

Merged
merged 8 commits into from Aug 21, 2023
Merged

Implement SPLICE function #1371

merged 8 commits into from Aug 21, 2023

Conversation

jinlee0
Copy link
Contributor

@jinlee0 jinlee0 commented Aug 12, 2023

resolves #1348

@coveralls
Copy link

coveralls commented Aug 12, 2023

Pull Request Test Coverage Report for Build 5909440080

  • 161 of 161 (100.0%) changed or added relevant lines in 6 files are covered.
  • 43 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 99.154%

Files with Coverage Reduction New Missed Lines %
core/src/ast/mod.rs 1 99.83%
core/src/executor/evaluate/mod.rs 3 99.38%
core/src/executor/execute.rs 9 96.33%
core/src/executor/aggregate/mod.rs 30 84.21%
Totals Coverage Status
Change from base Build 5877755511: -0.04%
Covered Lines: 49217
Relevant Lines: 49637

💛 - Coveralls

@jinlee0
Copy link
Contributor Author

jinlee0 commented Aug 12, 2023

@panarch
I think I'm ready for a review!

@panarch panarch added the enhancement New feature or request label Aug 12, 2023
@jinlee0 jinlee0 requested a review from panarch August 19, 2023 11:03
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Empty(I0),
Single(I1),
Double(I2),
Triple(I3),
VariableArgs(I4),
VariableArgsWithSingle(I5),
Quadruple(I6),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to create a Quadruple instead of a VariableArgs? @panarch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, both can be accepted so this decision which adds Quadruple looks also good.

nit. it would be better to add Quadruple in between Triple and VariableArgs rather than adding it to the last.

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot 👍 👍

Empty(I0),
Single(I1),
Double(I2),
Triple(I3),
VariableArgs(I4),
VariableArgsWithSingle(I5),
Quadruple(I6),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, both can be accepted so this decision which adds Quadruple looks also good.

nit. it would be better to add Quadruple in between Triple and VariableArgs rather than adding it to the last.

@panarch panarch merged commit ecc6fdf into gluesql:main Aug 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SPLICE function
4 participants