-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SPLICE
function
#1371
Conversation
Pull Request Test Coverage Report for Build 5909440080
💛 - Coveralls |
@panarch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Empty(I0), | ||
Single(I1), | ||
Double(I2), | ||
Triple(I3), | ||
VariableArgs(I4), | ||
VariableArgsWithSingle(I5), | ||
Quadruple(I6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct to create a Quadruple
instead of a VariableArgs
? @panarch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now, both can be accepted so this decision which adds Quadruple looks also good.
nit. it would be better to add Quadruple in between Triple and VariableArgs rather than adding it to the last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all nice! Thanks a lot 👍 👍
Empty(I0), | ||
Single(I1), | ||
Double(I2), | ||
Triple(I3), | ||
VariableArgs(I4), | ||
VariableArgsWithSingle(I5), | ||
Quadruple(I6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now, both can be accepted so this decision which adds Quadruple looks also good.
nit. it would be better to add Quadruple in between Triple and VariableArgs rather than adding it to the last.
resolves #1348