Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .unwrap() uses in test-suite/ test codes, #1372

Merged
merged 3 commits into from Aug 12, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Aug 12, 2023

Change "async move {..}" test case declaration code to use simple "{..}".
Then, we can replace .unwrap() to ?.

Change "async move {..}" test case declaration code to use simple "{..}".
Then, we can replace .unwrap() to ?.
@panarch panarch added the improvement Improvements for existing features label Aug 12, 2023
@coveralls
Copy link

coveralls commented Aug 12, 2023

Pull Request Test Coverage Report for Build 5840391269

  • 145 of 316 (45.89%) changed or added relevant lines in 87 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.857%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/data_type/decimal.rs 2 3 66.67%
test-suite/src/function/ascii.rs 2 3 66.67%
test-suite/src/function/chr.rs 2 3 66.67%
test-suite/src/function/values.rs 1 2 50.0%
test-suite/src/show_columns.rs 0 1 0.0%
test-suite/src/type_match.rs 1 2 50.0%
test-suite/src/validate/types.rs 3 4 75.0%
test-suite/src/aggregate/avg.rs 0 2 0.0%
test-suite/src/aggregate/count.rs 0 2 0.0%
test-suite/src/aggregate/error.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 5840104161: -0.3%
Covered Lines: 47237
Relevant Lines: 47783

💛 - Coveralls

@panarch panarch merged commit 0fddbf4 into main Aug 12, 2023
9 checks passed
@panarch panarch deleted the remove-unwrap-uses-in-test-suite branch August 12, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants