Feature: redis storage #1396
Merged
Feature: redis storage #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
devgony,
ever0de,
panarch and
zmrdltl
gurugio
force-pushed
the
feature/redis-storage
branch
from
7688144
to
ffc050a
Compare
gurugio
force-pushed
the
feature/redis-storage
branch
from
c40a6a3
to
9f259f2
Compare
gurugio
force-pushed
the
feature/redis-storage
branch
8 times, most recently
from
5ebeff7
to
5ed4765
Compare
Pull Request Test Coverage Report for Build 6832207731
💛 - Coveralls |
gurugio
force-pushed
the
feature/redis-storage
branch
2 times, most recently
from
6a126dc
to
93de0f6
Compare
gurugio
force-pushed
the
feature/redis-storage
branch
2 times, most recently
from
b86f91d
to
c059dc9
Compare
panarch
reviewed
Oct 7, 2023
panarch
reviewed
Oct 15, 2023
panarch
reviewed
Oct 15, 2023
panarch
requested changes
Nov 4, 2023
no functional change
No functional change
gurugio
force-pushed
the
feature/redis-storage
branch
from
53297c0
to
7e67db1
Compare
Store Redis server address and port number in an extra file. Each test reads the file when connecting the Redis server
panarch
requested changes
Nov 5, 2023
storages/redis-storage/Cargo.toml
Outdated
| [dev-dependencies] | ||
| test-suite.workspace = true | ||
| tokio = { version = "1", features = ["rt", "macros"] } | ||
| futures = "0.3" |
There was a problem hiding this comment.
futures is already declared in [dependencies] so we can remove it here.
storages/redis-storage/Cargo.toml
Outdated
| serde_json = "1.0.105" | ||
| chrono = { version = "=0.4.31", features = ["serde", "wasmbind"] } | ||
| futures = "0.3" | ||
| toml = "0.8.6" |
There was a problem hiding this comment.
toml is currently only used in tests/ so we can declare it in dev-dependencies rather than dependencies.
storages/redis-storage/Cargo.toml
Outdated
| serde = { version = "1", features = ["derive"] } | ||
| redis = "0.23.3" | ||
| serde_json = "1.0.105" | ||
| chrono = { version = "=0.4.31", features = ["serde", "wasmbind"] } |
There was a problem hiding this comment.
is there any reason to specify =0.4.31? it would be enough to use 0.4.31.
gurugio
force-pushed
the
feature/redis-storage
branch
from
c60a8e9
to
5dea5c8
Compare
panarch
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working for Redis storage.
There are many patches at the moment. I will rebase them into one patch later.
Please check the latest code.