fix: Literal comparison with BinaryOperator #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator when lteq, gteq comp
github-actions
bot
requested review from
devgony,
ever0de,
panarch and
zmrdltl
|
It seems better to create a branch from the latest |
Thank you! |
panarch
requested changes
Sep 9, 2023
core/src/executor/evaluate/expr.rs
Outdated
Comment on lines
52
to
57
| BinaryOperator::LtEq => { | ||
| if l.evaluate_cmp(&r).is_none() { | ||
| return Ok(Evaluated::from(Value::Bool(false))); | ||
| } | ||
| cmp!(l.evaluate_cmp(&r) != Some(Ordering::Greater)) | ||
| } |
There was a problem hiding this comment.
matches! would be useful. same approach can be applied for BinaryOperator::GtEq
BinaryOperator::LtEq => cmp!(matches!(
l.evaluate_cmp(&r),
Some(Ordering::Less) | Some(Ordering::Equal)
)),There was a problem hiding this comment.
Wow! matches! macro thank you~
Pull Request Test Coverage Report for Build 6145793371
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1306