Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove implementation of from<Value> trait for Evaluated #1399

Merged
merged 1 commit into from Sep 9, 2023
Merged

refactor: remove implementation of from<Value> trait for Evaluated #1399

merged 1 commit into from Sep 9, 2023

Conversation

tgsong827
Copy link
Contributor

resolves #1328
then #1330 can be closed

@ever0de ever0de added the improvement Improvements for existing features label Sep 2, 2023
panarch
panarch approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also the nice refactoring! Thanks a lot 👍

@panarch panarch merged commit 5275c76 into gluesql:main Sep 9, 2023
10 checks passed
@ever0de ever0de mentioned this pull request Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

@zmrdltl zmrdltl Awaiting requested review from zmrdltl

Assignees

@tgsong827 tgsong827

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove From<Value> for Evaluated<'a>
3 participants
@tgsong827 @panarch @ever0de