Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement ConvertError, #1401

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Sep 2, 2023

resolved #1390

TODO

Create a parent error that also tracks which column, ast, ... it occurs in.

@ever0de ever0de added the improvement Improvements for existing features label Sep 2, 2023
@ever0de ever0de force-pushed the chore/impl-convert-error-add-information-to-impossible-cast branch from 5fc19fb to 960c1d9 Compare September 2, 2023 16:49
- add information to `ImpossibleCast` error
@ever0de ever0de force-pushed the chore/impl-convert-error-add-information-to-impossible-cast branch from 960c1d9 to 7f9ec31 Compare September 2, 2023 17:04
@ever0de ever0de marked this pull request as ready for review September 2, 2023 17:04
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's brilliant to split errors by adding a new local one.
ConvertError looks great! Thanks a lot 👍 👍

@panarch panarch merged commit a518003 into gluesql:main Sep 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make impossible cast error more meaningful
2 participants