Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: write docmentation for padding #1434

Merged
merged 2 commits into from
Oct 29, 2023
Merged

docs: write docmentation for padding #1434

merged 2 commits into from
Oct 29, 2023

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Oct 29, 2023

Todo

  • write docmentation for ast-builder/functions/text/padding

@devgony devgony changed the title Write docmentation for padding docs: write docmentation for padding Oct 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6681095185

  • 28 of 29 (96.55%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 98.586%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/function/text/padding.rs 28 29 96.55%
Totals Coverage Status
Change from base Build 6680850161: -0.001%
Covered Lines: 50346
Relevant Lines: 51068
💛 - Coveralls

panarch
panarch approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks also nice :) Thanks a lot!

@panarch panarch merged commit e248963 into gluesql:main Oct 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

@zmrdltl zmrdltl Awaiting requested review from zmrdltl

Assignees

@devgony devgony

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devgony @coveralls @panarch