Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Quotes #145

Merged
merged 2 commits into from Feb 27, 2021
Merged

Single Quotes #145

merged 2 commits into from Feb 27, 2021

Conversation

KyGost
Copy link
Contributor

@KyGost KyGost commented Feb 27, 2021 •
edited

Relates to #76

@KyGost KyGost mentioned this pull request Feb 27, 2021
Closed
@panarch panarch self-requested a review February 27, 2021 10:12
@panarch panarch added the enhancement New feature or request label Feb 27, 2021
@KyGost
Copy link
Contributor Author

KyGost commented Feb 27, 2021

Note: bug not enhancement
(Though I suppose they have arbitrary differences)

KyGost
KyGost commented Feb 27, 2021
View reviewed changes
src/data/value.rs Outdated Show resolved Hide resolved
panarch
panarch requested changes Feb 27, 2021
View reviewed changes
src/data/value.rs Outdated Show resolved Hide resolved
@panarch panarch self-requested a review February 27, 2021 11:42
panarch
panarch approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 👍 👍

@panarch panarch merged commit ca757c5 into gluesql:main Feb 27, 2021
@KyGost KyGost deleted the single_quotes branch February 27, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@KyGost KyGost

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KyGost @panarch