-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INSERT tests and fixes #199
Conversation
I really appreciate on this work, thanks! solving three insertion issues. |
Please see it as improving insertion code and adding better tests and just also solving some bugs at the same time as that is what this is. |
Oh oops I didn't push my recent changes |
* Remade for v0.5 * Clippy * Appease no defaults clippy * Clean up generate * Remove sled transaction and use ColumnOptionExt for AutoIncrement column option check * Clip * Improvements * Clippy * No Mut change * Minimize work in storage * Split get and set * Clip * Move row mutation to end, make procedures occur in two segments. * Clean up a little, Clip * Better testing * Stuff for clippy reasons * Revert "Stuff for clippy reasons" This reverts commit 99956a6. * Ignore clippy stuff for now, should be fixed in different PR * Use a transaction * Clippy and remove acceptance of AUTOINCREMENT
* Working * Move more into optional feature
Why are these in this PR?!?!?! |
Oh.. now I see that..
These are independent issues, if you can split this PR into three, then I can fastly review one by one. |
Please, once again, ignore the fixes. This is a rewrite of how we compile rows and insert data. |
* Remade for v0.5 * Clippy * Appease no defaults clippy * Clean up generate * Remove sled transaction and use ColumnOptionExt for AutoIncrement column option check * Clip * Improvements * Clippy * No Mut change * Minimize work in storage * Split get and set * Clip * Move row mutation to end, make procedures occur in two segments. * Clean up a little, Clip * Better testing * Stuff for clippy reasons * Revert "Stuff for clippy reasons" This reverts commit 99956a6. * Ignore clippy stuff for now, should be fixed in different PR * Use a transaction * Clippy and remove acceptance of AUTOINCREMENT
Closing PRs which are merged and working well in the fork. |
Resolve: #197
Resolve: #190
Resolve: #189