Add functions: ASIN(), ACOS(), ATAN() #296
Conversation
|
Let me fix clippy error and pull request again. |
|
Resolved clippy error. |
src/executor/evaluate/error.rs
Outdated
|
|
||
| #[error("out of range: {0}")] | ||
| OutOfRange(String), |
There was a problem hiding this comment.
Ok, here let's simply depend on Rust compiler.
Rust compiler will return NaN and we can use that rather than returning explicit error.
src/executor/evaluate/mod.rs
Outdated
| Value::F64(v) => Some(v), | ||
| Value::Str(v) => match f64::from_str(&v) { | ||
| Ok(f) => Some(f), | ||
| Err(_) => None, | ||
| }, | ||
| Value::I64(v) => f64::from_i64(v), | ||
| _ => None, |
There was a problem hiding this comment.
Now, let's make the spec clear.
You can only accept three types; F64, I64 and Null.
Except for these three types, FunctionReuqiresFloatValue can be the one to return.
F64 - we can use directly.
I64 - as f64 to cast and we can use that.
Null -> then return value becomes also null.
resolve conflict
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 90.95% 91.01% +0.06%
==========================================
Files 126 126
Lines 7714 7770 +56
==========================================
+ Hits 7016 7072 +56
Misses 698 698
Continue to review full report at Codecov.
|
src/executor/evaluate/mod.rs
Outdated
| let number = match eval(expr).await?.try_into()? { | ||
| Value::F64(v) => Some(v), | ||
| Value::I64(v) => f64::from_i64(v), | ||
| Value::Null => return Ok(Evaluated::from(Value::Null)), | ||
| _ => None, | ||
| }; | ||
|
|
||
| match number { | ||
| Some(v) => Ok(Evaluated::from(Value::F64(v.asin()))), | ||
| None => Err( | ||
| EvaluateError::FunctionRequiresFloatOrIntegerValue("ASIN".to_owned()).into(), | ||
| ), | ||
| } |
There was a problem hiding this comment.
Behavior really looks good.
For this, let's use eval_to_float closure which is used by all other functions to take float values.
eval_to_float can provide consistent behavior through float param type functions.
You can apply this to ASin, ACos and ATan.
Add
ASIN(),ACOS(),ATAN()functions.These functions support numeric string literals and boolean and floating numbers.
resolve #285
referenced @maruoovv 's pull request a lot.