Implement REPEAT Function #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panarch
requested changes
Sep 15, 2021
src/executor/evaluate/mod.rs
Outdated
Comment on lines
585
to
587
| Nullable::Null => { | ||
| return Ok(Evaluated::from(Value::Null)); | ||
| } |
There was a problem hiding this comment.
Let's just have a single more test case.
Precisely, this Nullable::Null is not tested by current repeat integration test
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 91.71% 91.73% +0.02%
==========================================
Files 138 139 +1
Lines 8434 8460 +26
==========================================
+ Hits 7735 7761 +26
Misses 699 699
Continue to review full report at Codecov.
|
panarch
reviewed
Oct 9, 2021
src/executor/evaluate/mod.rs
Outdated
| Function::Repeat { expr, num } => { | ||
| let expr = eval_to_str!(expr); | ||
| let num = eval_to_integer!(num); | ||
| Ok(Value::Str(expr.repeat(num.try_into().unwrap()))) |
There was a problem hiding this comment.
You don't need to use unwrap().
num.try_into()? will work.
panarch
reviewed
Oct 9, 2021
src/tests/function/repeat.rs
Outdated
| use crate::*; | ||
|
|
||
| test_case!(repeat, async move { | ||
| //use Value::{Null, Str, I64}; |
panarch
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.