Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ceil function #645

Merged
merged 6 commits into from
Jul 15, 2022
Merged

implement ceil function #645

merged 6 commits into from
Jul 15, 2022

Conversation

jaeyoung0909
Copy link
Contributor

@jaeyoung0909 jaeyoung0909 commented Jul 14, 2022 •
edited

Resolves #642

@ever0de ever0de added the enhancement New feature or request label Jul 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #645 (83d3468) into main (fab6e71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         217      217           
  Lines       16469    16481   +12     
=======================================
+ Hits        15536    15548   +12     
  Misses        933      933
Impacted Files Coverage Δ
core/src/ast_builder/mod.rs 100.00% <ø> (ø)
core/src/ast_builder/expr/function.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab6e71...83d3468. Read the comment docs.

ever0de
ever0de approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

MRGRAVITY817
MRGRAVITY817 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@MRGRAVITY817 MRGRAVITY817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

panarch
panarch approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks nice! Thanks a lot 👍

@panarch panarch merged commit 7978f64 into gluesql:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

@MRGRAVITY817 MRGRAVITY817 MRGRAVITY817 approved these changes

@24seconds 24seconds Awaiting requested review from 24seconds

@devgony devgony Awaiting requested review from devgony

Assignees

@jaeyoung0909 jaeyoung0909

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AST Builder] Implement CEIL function
5 participants
@jaeyoung0909 @codecov-commenter @panarch @ever0de @MRGRAVITY817