-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ColumnOption::{Null, NotNull} into a single option #986
Conversation
Pull Request Test Coverage Report for Build 3421124370
💛 - Coveralls |
619aec6
to
9e3a076
Compare
9e3a076
to
693f2f5
Compare
core/src/data/row.rs
Outdated
@@ -118,7 +117,7 @@ impl Row { | |||
} = column_def; | |||
|
|||
value.validate_type(data_type)?; | |||
value.validate_null(nullable)?; | |||
value.validate_null(nullable.to_owned())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to_owned()
for Copy
impl value might be.. too much.
you can simply use *nullable
for these cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also the meaningful improvement.
Looks so so good.
Thanks a lot 👍
To resolve #969,
Goal
Add nullable field To ColumnDef
Remove redundant ColumnOption::{NotNull, Null}
Todo
Next