Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply binary_op macros to existing data types #987

Merged
merged 9 commits into from
Nov 19, 2022
Merged

Apply binary_op macros to existing data types #987

merged 9 commits into from
Nov 19, 2022

Conversation

ChobobDev
Copy link
Contributor

No description provided.

@ChobobDev ChobobDev marked this pull request as ready for review November 5, 2022 08:57
@coveralls
Copy link

coveralls commented Nov 5, 2022 •
edited

Pull Request Test Coverage Report for Build 3501934111

  • 92 of 92 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 98.693%
Totals Coverage Status
Change from base Build 3489369541: 0.3%
Covered Lines: 36776
Relevant Lines: 37263
💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Nov 6, 2022
ever0de
ever0de approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved readability and clearer code Thank you 👍

panarch
panarch approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thanks a lot 👍

@panarch panarch changed the title feat: chage data type file strcuture and apply macros Apply binary_op macros to existing data types Nov 19, 2022
@panarch panarch merged commit 2542a72 into gluesql:main Nov 19, 2022
@ChobobDev ChobobDev deleted the feature/int_data_type branch November 19, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@ChobobDev ChobobDev

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChobobDev @coveralls @panarch @ever0de