Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace double quote to single quote #988

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Nov 5, 2022

Goal

Let's use single quote only for sql literal string

SELECT 'literal';

Todo

  • refactor: replace double quote to single quote

Next

  • fix translate to handle double qoute for Identifier

@devgony devgony added the enhancement New feature or request label Nov 5, 2022
@devgony devgony self-assigned this Nov 5, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3398899427

  • 52 of 53 (98.11%) changed or added relevant lines in 7 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 97.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/ast/ast_literal.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 7 81.82%
Totals Coverage Status
Change from base Build 3393980888: -0.02%
Covered Lines: 38495
Relevant Lines: 39337

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of that SQL handles single quoted & double quoted differently.
Thanks a lot! Looks all nice

@panarch panarch merged commit 427b827 into gluesql:release-v0.13.1 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants