Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify default ColumnOption from NOT NULL to NULL #997

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Nov 10, 2022

To resolve #974

Goal

For better user experience, Let's modify default ColumnDef.nullable from false to true

CREATE TABLE Items (id INT);

Before

TABLE_NAME COLUMN_NAME NULLABLE
Items id NOT NULL

After

TABLE_NAME COLUMN_NAME NULLABLE
Items id NULL

Todo

  • modify default ColumnDef.nullable from false to true
  • add Column name validation and RowErr::WrongColumnName)

@devgony devgony added the enhancement New feature or request label Nov 10, 2022
@devgony devgony self-assigned this Nov 10, 2022
@coveralls
Copy link

coveralls commented Nov 10, 2022

Pull Request Test Coverage Report for Build 3458000253

  • 26 of 26 (100.0%) changed or added relevant lines in 6 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 98.387%

Files with Coverage Reduction New Missed Lines %
core/src/executor/context/filter_context.rs 4 93.44%
test-suite/src/tester/mod.rs 19 87.5%
Totals Coverage Status
Change from base Build 3451101516: -0.05%
Covered Lines: 39887
Relevant Lines: 40541

💛 - Coveralls

@devgony devgony marked this pull request as ready for review November 14, 2022 02:13
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot 👍

@panarch panarch merged commit 12afef7 into gluesql:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify default ColumnOption from NOT NULL to NULL
4 participants