This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Rename !include to !import-variables #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New name is more fitting, because we're actually not including anything into the file itself, but importing a set of variables into the namespace available to macros in the file. The old name also clashed with the actual !include directive recommended to be used to include data into the YAML structure, and we will need that directive one day, therefore getting rid of ambiguity.
mkluson
approved these changes
Nov 4, 2019
thrix
approved these changes
Nov 4, 2019
|
@thrix it will indeed break the configuration, AFAIK it's just us who are using this particular feature, and our tests will stop us from not fixing the configuration for sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New name is more fitting, because we're actually not including anything
into the file itself, but importing a set of variables into the
namespace available to macros in the file. The old name also clashed
with the actual !include directive recommended to be used to include
data into the YAML structure, and we will need that directive one day,
therefore getting rid of ambiguity.