Fix derive Getable for tuple structs #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 5, 2018
546: Fix derive Getable for tuple structs r=Marwes a=Laegluin When using the new derive macros, I noticed that tuple structs caused panics when deriving `Getable`, because that branch was not implemented. This fixes the problem and also adds `#[allow(unused_variables)]` to the generated code (occurs when using C-style enums, that do not use the `vm` parameter). Co-authored-by: Robin Mirow <robinmirow@live.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new derive macros, I noticed that tuple structs caused panics when deriving
Getable, because that branch was not implemented. This fixes the problem and also adds#[allow(unused_variables)]to the generated code (occurs when using C-style enums, that do not use thevmparameter).