Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live preview vs. actual markdown formatting mismatch #1065

Closed
relikd opened this issue Feb 1, 2021 · 8 comments
Closed

Live preview vs. actual markdown formatting mismatch #1065

relikd opened this issue Feb 1, 2021 · 8 comments
Assignees

Comments

@relikd
Copy link

relikd commented Feb 1, 2021

Describe the bug
Styling (like underscores) inside code environment is applied to text outside of the environment.

To Reproduce

replace `_10` with `_1`

Expected behavior
The code environment should ignore all markdown commands until the environment is closed.

Actual behavior
See image. The with in between shouldn't be italic in the live preview.

Workaround
None. ... Actually thats funny and leads me to another bug: \_hi there\_ should escapte the underscore and print the text without italics, however the live preview still shows formatting (see screen2)

Supporting Files
screen
screen2

Desktop (please complete the following information):

  • OS: macOS
  • OS version: 10.15.7
  • FSNotes version: 4.9.5

Additional context
NA

@relikd relikd added the bug label Feb 1, 2021
glushchenko added a commit that referenced this issue Feb 3, 2021
@glushchenko
Copy link
Owner

Fixed in 4.9.6 https://github.com/glushchenko/fsnotes/releases/download/4.9.6/FSNotes.zip

@relikd relikd closed this as completed Feb 3, 2021
@relikd
Copy link
Author

relikd commented Feb 3, 2021

A small addendum, the underscore "hi there" example is still rendered italic in the live preview, even though it shouldn't.

@relikd relikd reopened this Feb 3, 2021
@glushchenko
Copy link
Owner

Live preview implemented by libcmark_gfm and should be addressed to https://github.com/github/cmark-gfm

@relikd
Copy link
Author

relikd commented Feb 3, 2021

Isnt cmark just the normal preview? I speak of the live preview you see before hitting the preview button. E.g., you fixed it for the "with" in the example above, but the "hi there" is on the same page but not fixed.

@glushchenko
Copy link
Owner

glushchenko commented Feb 3, 2021

Escaping by slash is in markdown spec?

@relikd
Copy link
Author

relikd commented Feb 3, 2021

at least in the cmark specs, yes. And github supports it, eg.: _here_ (<-- \_here\_)

glushchenko added a commit that referenced this issue Feb 5, 2021
@glushchenko
Copy link
Owner

Fixed!

@glushchenko
Copy link
Owner

https://github.com/glushchenko/fsnotes/releases/download/4.9.7beta/FSNotes.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants