Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note list text is not full width (if shown as sidebar) #1066

Closed
relikd opened this issue Feb 1, 2021 · 12 comments
Closed

Note list text is not full width (if shown as sidebar) #1066

relikd opened this issue Feb 1, 2021 · 12 comments
Assignees

Comments

@relikd
Copy link

relikd commented Feb 1, 2021

Describe the bug
The entries in the sidebar are not using the full available width to display the text content. In the image below the text is "Knowledge" which would fit easily in the cell content but it seems something invisible is taking up space from the right.

To Reproduce
NA

Expected behavior
The text should use the full width if nothing else is displayed in the cell.

Actual behavior
Text is truncated unnecessarily and leaves an unused whitespace at the end.

Workaround
None.

Supporting Files
screen

Desktop (please complete the following information):

  • OS: macOS
  • OS version: 10.15.7
  • FSNotes version: 4.9.5

Additional context
NA

@glushchenko
Copy link
Owner

How to reproduce it?

@relikd
Copy link
Author

relikd commented Feb 2, 2021

For me it is always like that. I dont need to do anything, it just is. You can resize the sidebar and see if the truncation starts too early. It has a fixed width from the right.

@relikd
Copy link
Author

relikd commented Feb 2, 2021

Untitled.mov

glushchenko added a commit that referenced this issue Feb 3, 2021
@glushchenko
Copy link
Owner

@relikd
Copy link
Author

relikd commented Feb 3, 2021

Nope, still there. Same distance as before. Do I need to to something?
Also, just figured, it is not the sidebar but the notes list.

@relikd relikd changed the title Sidebar text is not full width Note list text is not full width (if shown as sidebar) Feb 3, 2021
@relikd
Copy link
Author

relikd commented Feb 3, 2021

And it may be a coincidence but the create-new-note icon above the list happens to be the exact space where it starts to truncate. As if the table is two column and the second column is only used for the new-note button.

@glushchenko
Copy link
Owner

Can you make video or screenshot?

@relikd
Copy link
Author

relikd commented Feb 3, 2021

Sure, but it literally is the same video as before:

Untitled.mov

@relikd
Copy link
Author

relikd commented Feb 3, 2021

The accessibility shows an insetted text field inside the cell.

screen
screen

glushchenko added a commit that referenced this issue Feb 5, 2021
@glushchenko
Copy link
Owner

Fixed! :)

@glushchenko
Copy link
Owner

glushchenko commented Feb 7, 2021

@relikd
Copy link
Author

relikd commented Feb 7, 2021

The distance is shorter but still there. Approx the same distance as the padding on the left side of the cell.
But that is good enough for me, I can live with it :) 🎉

@relikd relikd closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants