Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of oddities #113

Closed
jeff-h opened this issue Feb 2, 2018 · 21 comments
Closed

Couple of oddities #113

jeff-h opened this issue Feb 2, 2018 · 21 comments
Labels

Comments

@jeff-h
Copy link
Contributor

jeff-h commented Feb 2, 2018

When in an RTF note, if you indent a line by pressing tab, the font, colour and background colour all change unexpectedly (perhaps something to do with a markdown feature?).

Also, when you're at the end of a note and press the down arrow, under some circumstances the scrollbar appears and the document jumps up and down by a line, all from just pressing the down arrow key repeatedly. You can see this at the end of the screencast below.

2018-02-02 15_51_41

glushchenko added a commit that referenced this issue Feb 4, 2018
@greendog99
Copy link
Contributor

greendog99 commented Feb 16, 2018

FYI, 1.2.9 still has the font/color/background issue when starting a line with tab (looks like it's trying to do code highlighting even though I have that turned off and this is not code).
ss-20180216-100948

glushchenko added a commit that referenced this issue Feb 22, 2018
- iOS background sync for initial data
@greendog99
Copy link
Contributor

The strange scrolling behavior is still happening in 1.2.11. Here's a more in-depth screencast showing the issue. All I'm doing is pressing the down arrow key once per second. You can see that when the cursor gets to the bottom of the screen, additional down arrow presses alternate between scrolling all the way back to the top, and then back to current position.

9a8u2orcls

glushchenko added a commit that referenced this issue Feb 24, 2018
@glushchenko
Copy link
Owner

glushchenko commented Feb 24, 2018

Please try build 105. Release 1.2.11 was updated.

@jeff-h
Copy link
Contributor Author

jeff-h commented Feb 24, 2018

Fixed! 😃 Thanks so much for all your hard work.

@jeff-h jeff-h closed this as completed Feb 24, 2018
@greendog99
Copy link
Contributor

Thanks! Build 105 resolves the scrolling issue I just shared above. However, it does still suffer from the original one-line scrolling issue that @jeff-h demonstrated when he opened this issue: "when you're at the end of a note and press the down arrow, under some circumstances the scrollbar appears and the document jumps up and down by a line, all from just pressing the down arrow key repeatedly."

That's far less annoying than the issue where it scrolled back to the top of the page, but it's still "odd". In doing a little testing, that issue seems to happen (in build 105) when the fsnotes window height does not match a multiple of the line height. I.e. if the bottom line of the note is only half visible in the window, this back-and-forth one line jump seems to happen when using the up/down arrows. If I resize the window to exactly match the line height, the problem goes away. Hope this helps!

@jeff-h
Copy link
Contributor Author

jeff-h commented Feb 24, 2018

Strange. I can't replicate the original problem in 1.2.11 (105). It really does seem fixed for me.

However, I'm re-opening this, since you do still see the issue.

@jeff-h jeff-h reopened this Feb 24, 2018
@greendog99
Copy link
Contributor

I'll try to capture a screencast tonight on (105)...

@greendog99
Copy link
Contributor

The odd one-line scrolling at the bottom of the note only seems to happen if there is an URL somewhere higher in the note, out of view. In this video I keep pressing down arrow until I reach the bottom and it works fine. Then I go near the top of the note and add an URL. Then back to the bottom and the odd scrolling happens when I press down arrow. Thanks for looking into it!

fya2xlxfg5

glushchenko added a commit that referenced this issue Feb 25, 2018
@glushchenko
Copy link
Owner

Build 106 should fix it. Please checkout.

@greendog99
Copy link
Contributor

Build 106 Fixed that specific test case, but I'm still running into a similar problem in many other files. It seems that the longer the note is, the worse the problem. Try loading the attached note, go to the bottom, and then use the up arrow to start moving up the note. Every press of the up arrow jumps the note around. Thanks again!
test.txt

@gingerbeardman
Copy link
Collaborator

@greendog99 I can't reproduce this using your test file. Does it happen on a new/guest account?

@greendog99
Copy link
Contributor

@gingerbeardman can you confirm that FSNotes recognized and formatted the URL at the top of the test file? If I undo the link formatting, the file works fine. I'll create a new account on my Mac and capture a screen recording there...

@greendog99
Copy link
Contributor

@gingerbeardman I can NOT reproduce on a new test account on my Mac. Not sure what that means, but I'll keep experimenting and report back if I can find a reliable way to reproduce it...

@gingerbeardman
Copy link
Collaborator

Yes, the link is formatted and clickable. https://youtu.be/SmbbNbrrJzs

If it doesn't happen on a new test account then it means it's something to do with the settings/prefs/apps you have running on your account.

Try logging in holding down shift to prevent your startup apps running, and see if it happens then. A painful process of elimination is ahead.

@greendog99
Copy link
Contributor

Preventing startup apps didn't help. I copied my notes folder over to my test account and the problem showed back up. I deleted all notes except the test note and it still happened. I ran sum on the test note in the working and failing folders and they have the same checksum. Not sure why it's happening using one notes folder but not the other.

However, I have been able to easily reproduce a possibly related issue using the new test account. When I create my test note and view it, my H1 header is displayed in bold. When I scroll past it with the cursor, it changes to plain text and the height of the lines around it changes. When I go to the bottom, I don't have the scrolling problem. Video below.

Interestingly, on my note that has the scrolling problem, the H1 text is never shown as bold on screen... it's always just plain text. I'll keep experimenting, but I thought the bold issue might be a clue and might be reproducible by others.
v1

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Feb 25, 2018

Syntax highlighting needs some attention.

the document has different behaviour if you name it .txt (no bold) or .md (bold that disappears) so I guess you created a .md file the second time?

@greendog99
Copy link
Contributor

greendog99 commented Feb 25, 2018

Correct. Here's a longer screencast showing the difference. This is on a new account on my Mac.

gif2

ss-20180225-104540

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Feb 25, 2018

I can reproduce that funky bold behaviour (but not the jumping document when moving lines).

Let's see what @glushchenko says, as I don't think we can solve this ourselves.

@glushchenko
Copy link
Owner

Thanks @gingerbeardman @greendog99, i reproduced all bugs. Will be fixed on the next week.

glushchenko added a commit that referenced this issue Feb 26, 2018
@glushchenko
Copy link
Owner

Guys, last build (107), should fix all oddities.

@greendog99
Copy link
Contributor

Looks good to me. Thanks!!

glushchenko added a commit that referenced this issue Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants