Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping images into the editor inserts newlines elsewhere #1142

Closed
tewe opened this issue Jul 3, 2021 · 3 comments
Closed

Dropping images into the editor inserts newlines elsewhere #1142

tewe opened this issue Jul 3, 2021 · 3 comments
Assignees
@glushchenko
Labels
bug done
Projects
FSNotes 5

Comments

@tewe
Copy link

tewe commented Jul 3, 2021

Describe the bug

When an image is dragged onto the editor, two newlines are inserted at the last cursor position, instead of at the drop point.

To Reproduce

Image.drop.2021-07-03.at.11.50.46.mp4

Desktop (please complete the following information):

  • OS: macOS
  • OS version: 10.14.6
  • FSNotes version: 4.10.2

Fix

EditTextView.swift

insertText("![](\(filePath))", replacementRange: insertRange)
insertNewline(nil)
insertNewline(nil)

Probably the insertNewline should also be given the insertRange somehow.
@tewe tewe added the bug label Jul 3, 2021
glushchenko added a commit that referenced this issue Jul 8, 2021
@glushchenko
#1142
94ff3f7
@glushchenko
Copy link
Owner

Thank you @tewe. Fixed!

@glushchenko glushchenko added this to To Do in FSNotes 5 via automation Jul 8, 2021
@glushchenko glushchenko moved this from To Do to Done in FSNotes 5 Jul 8, 2021
@glushchenko
Copy link
Owner

Please test https://github.com/glushchenko/fsnotes/releases/tag/5beta1

@tewe
Copy link
Author

tewe commented Jul 11, 2021

The beta removes the newlines completely, which works for me.

@tewe tewe closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glushchenko glushchenko

Labels
bug done
Projects
No open projects
FSNotes 5
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tewe @glushchenko