Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing parentheses not part of URL #1236

Closed
tewe opened this issue Nov 2, 2021 · 6 comments
Closed

Trailing parentheses not part of URL #1236

tewe opened this issue Nov 2, 2021 · 6 comments
Assignees

Comments

@tewe
Copy link

tewe commented Nov 2, 2021

Description

URLs with parentheses (as are common on WikiPedia) work fine in the Markdown preview. While editing the trailing parentheses is not recognized as part of the address, so clicking it goes 404.

To Reproduce

  1. Start a new note
  2. paste https://en.wikipedia.org/wiki/Cowboy_Bebop_(2021_TV_series)
  3. click the highlighted URL

Expected behavior

URL recognition in the editor uses the same algorithm as when rendering the preview.

FSNotes version

5.1.2

macOS/iOS version

macOS 10.14.6

Additional context

No response

@tewe tewe added the bug label Nov 2, 2021
glushchenko added a commit that referenced this issue Jan 8, 2022
@glushchenko
Copy link
Owner

@tewe
Copy link
Author

tewe commented Jan 9, 2022

Works for me! But it seems to slightly break highlighting: the trailing parentheses in Markdown links like [FSNotes](https://fsnot.es) is now blue instead of grey. This does not change the URL that gets opened.

glushchenko added a commit that referenced this issue Jan 11, 2022
@glushchenko
Copy link
Owner

@tewe
Copy link
Author

tewe commented Jan 12, 2022

Now for [FSNotes](https://fsnot.es) all brackets and parentheses are grey :)

But for [FSNotes](https://fsnot.es). (e.g. dot at the end of a sentence) both parentheses are blue?!

glushchenko added a commit that referenced this issue May 4, 2022
@glushchenko
Copy link
Owner

@tewe
Copy link
Author

tewe commented Aug 13, 2022

https://en.wikipedia.org/wiki/The_Menagerie_(Star_Trek:_The_Original_Series) open the correct page, but the closing parenthesis is not highlighted.

CleanShot 2022-08-13 at 11 28 05@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants