Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting cmd+delete in Find/Replace field trashes active note #1268

Closed
hpaves opened this issue Dec 28, 2021 · 3 comments
Closed

Hitting cmd+delete in Find/Replace field trashes active note #1268

hpaves opened this issue Dec 28, 2021 · 3 comments
Assignees

Comments

@hpaves
Copy link

hpaves commented Dec 28, 2021

Description

In macOS, cmd+delete has two main behaviors:

  1. while in a text field, it deletes everything from the cursor to the beginning of the line
  2. while having file(s) selected, it trashes the file(s)

This all works in FSnotes as expected, EXCEPT when you're in the Find/Replace fields. In there, hitting cmd+delete trashes the active note instead of deleting the text field content.

To Reproduce

  1. Open any note
  2. Hit cmd+f
  3. Write something into the find field
  4. Hit cmd+delete
  5. See the active note disappear (into the trash)

Expected behavior

In step 5: The content of the find field is deleted from the cursor to the beginning of the line. The active note is NOT trashed.

FSNotes version

5.2.0 (507)

macOS/iOS version

macOS 10.15.7 (19H1519)

Additional context

Identical issue is present in the Replace field.

@hpaves hpaves added the bug label Dec 28, 2021
glushchenko added a commit that referenced this issue Dec 30, 2021
@glushchenko
Copy link
Owner

Fixed, thanks!

@glushchenko
Copy link
Owner

@hpaves
Copy link
Author

hpaves commented Jan 9, 2022

Perfect! Thank you so much.

@hpaves hpaves closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants