Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Improve selected/focus highlights #316

Closed
gingerbeardman opened this issue Aug 1, 2018 · 9 comments
Closed

[REQ] Improve selected/focus highlights #316

gingerbeardman opened this issue Aug 1, 2018 · 9 comments

Comments

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Aug 1, 2018

From: #315 (comment)

Return steps towards the right (in)
+Return steps towards the left (out)

but it's not easy to see which column you are in (except if you can see the cursor when in the note)

I think perhaps current focus could be better represented through highlight colours?

  • blue = "selected with focus"
  • grey = "selected without focus"

left (folders/tags list)

  • current folder should be blue

screen shot 2018-08-01 at 13 39 36


middle (note list)

  • OK, focus is obvious and correct (note)
  • this is what you are looking for to delete using +Backspace

screen shot 2018-08-01 at 13 39 40


right (note content)

  • middle should be grey?
  • arguably you should be able to delete the note you are in, if you can copy the note you are in?

screen shot 2018-08-01 at 13 40 15

@jeff-h
Copy link
Contributor

jeff-h commented Aug 1, 2018

I think it would also be cool if you could use +left/right arrow to navigate — I never realised return and +return did anything in this context.

@gingerbeardman
Copy link
Collaborator Author

@jeff-h love that idea

@gingerbeardman gingerbeardman changed the title Improve selected/focus highlights [REQ] Improve selected/focus highlights Aug 2, 2018
@peavine
Copy link

peavine commented Aug 3, 2018

I like @gingerbeardman's suggestion:

blue = selected with focus
grey = selected without focus

Keyboard shortcuts to navigate are important but I'm not sure Command-Left Arrow and Command-Right Arrow would be the best choice. I say that because these shortcuts are commonly used (including in FSNotes) as a document shortcut:

Command–Left Arrow: Move the insertion point to the beginning of the current line.

Command–Right Arrow: Move the insertion point to the end of the current line.

https://support.apple.com/en-us/HT201236

@gingerbeardman
Copy link
Collaborator Author

gingerbeardman commented Aug 3, 2018

Good point! If we think of each column as tabs, how about (from previous apple link) reusing some of these shortcuts (ignore what it says they do here)

Command–Left Bracket ([): Go to the previous folder.
Command–Right Bracket (]): Go to the next folder.
Command–Up Arrow: Open the folder that contains the current folder.
Command–Control–Up Arrow: Open the folder that contains the current folder in a new window.
Command–Down Arrow: Open the selected item.

@peavine
Copy link

peavine commented Aug 3, 2018

My preference would be to use Command-Left/Right Bracket to navigate. Currently they are shortcuts for Format > Shift Left/Right, but perhaps these could be changed to something different.

Command-Up/Down Arrow are fairly important document shortcuts that move the cursor to the beginning and end of a document. I wouldn't change those.

@gingerbeardman
Copy link
Collaborator Author

In Safari, I change between tabs using Cmd+Shift+Left/Right it just occurred to me now that might be suitable?

@peavine
Copy link

peavine commented Aug 3, 2018

That's certainly a possibility. If the FSNotes menu bar contained a menu item for this (as there is in Safari), then users would have the option to change the shortcut to whatever they like.

@jeff-h
Copy link
Contributor

jeff-h commented Aug 4, 2018

My preference would be to use Command-Left/Right Bracket to navigate. Currently they are shortcuts for Format > Shift Left/Right, but perhaps these could be changed to something different.

In code editors at least, these shortcuts are very widely expected to do exactly what they currently do in FSNotes — ie indent / de-indent. Even Xcode has this... thus I'd strongly hope they stay as-is because I write code a lot lol

@glushchenko glushchenko added this to To Do in FSNotes 5 via automation Jul 4, 2021
glushchenko added a commit that referenced this issue Jul 7, 2021
@glushchenko glushchenko moved this from To Do to Done in FSNotes 5 Jul 7, 2021
@glushchenko
Copy link
Owner

Please test https://github.com/glushchenko/fsnotes/releases/tag/5beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants