Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Keyboard Shorcut #593

Closed
ghost opened this issue May 21, 2019 · 7 comments
Closed

Link Keyboard Shorcut #593

ghost opened this issue May 21, 2019 · 7 comments

Comments

@ghost
Copy link

ghost commented May 21, 2019

More typical for links in markdown apps is ⌘ + k

I didn't see a conflict, but this would be appreciative.

@peavine
Copy link

peavine commented May 21, 2019

FWIW, the Command-K keyboard shortcut is already in use for navigating the Note list (see closed issue #83).

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented May 31, 2019

@spencerclrk you can remap the shortcut yourself

Interestingly, choosing Cmd+K for Link doesn't stop Cmd+K from working in the notes list.

You can assign your own using: System Preferences > Keyboard > Shortcuts

Untitled

which shows as:
Screen shot 2019-05-31 at 12 11 15

and in FSNotes:
Screen shot 2019-05-31 at 12 11 32

I've also added a Wiki page for this: https://github.com/glushchenko/fsnotes/wiki/Custom-keyboard-shortcuts

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented May 31, 2019

I wonder if there's a bigger ask to make keyboard shortcuts more common/expected/universal?

@ghost
Copy link
Author

ghost commented May 31, 2019

For me, even after remapping ⌘ + K is still navigating the notes.

But yes, it would make more sense to have the keyboard shortcuts more in-line with what other markdown apps (or even Mail.app) does in handing basic shortcuts.

@gingerbeardman
Copy link
Collaborator

Not sure what I did earlier but I can confirm that Cmd+K still navigates notes even when set as custom key combo

@Vipoli
Copy link

Vipoli commented Apr 20, 2021

Also I confirm the same problem (it still navigates notes). I tried to remap "Link" command with the combination "Shift+Cmd+K", but it doesn't work too.

@glushchenko glushchenko added this to To Do in FSNotes 5 via automation Jul 8, 2021
glushchenko added a commit that referenced this issue Jul 9, 2021
@glushchenko glushchenko moved this from To Do to Done in FSNotes 5 Jul 9, 2021
@glushchenko
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants