update kubernetes version to v1.12.1

[Madhu-1]

updated node plugin template which is required for kubernetes v1.12.1.

Signed-off-by: Madhu Rajanna mrajanna@redhat.com

output

kubectl version

kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.1", GitCommit:"4ed3216f3ec431b140b1d899130a69fc671678f4", GitTreeState:"clean", BuildDate:"2018-10-05T16:36:14Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.1", GitCommit:"4ed3216f3ec431b140b1d899130a69fc671678f4", GitTreeState:"clean", BuildDate:"2018-10-05T16:36:14Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

pod status

[vagrant@kube1 ~]$ kubectl get po
NAME          READY   STATUS    RESTARTS   AGE
gcs-example   1/1     Running   0          45s

[vagrant@kube1 ~]$ kubectl describe po/gcs-example
Name:               gcs-example
Namespace:          default
Priority:           0
PriorityClassName:  <none>
Node:               kube2/192.168.121.31
Start Time:         Thu, 11 Oct 2018 13:22:28 +0000
Labels:             app=redis
Annotations:        <none>
Status:             Pending
IP:                 
Containers:
  redis:
    Container ID:   
    Image:          redis:latest
    Image ID:       
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /data from gcs-example-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-v8znv (ro)
Conditions:
  Type              Status
  Initialized       True 
  Ready             False 
  ContainersReady   False 
  PodScheduled      True 
Volumes:
  gcs-example-volume:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  gcs-example-volume
    ReadOnly:   false
  default-token-v8znv:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-v8znv
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason                  Age                From                     Message
  ----     ------                  ----               ----                     -------
  Warning  FailedScheduling        19s (x9 over 36s)  default-scheduler        pod has unbound immediate PersistentVolumeClaims (repeated 3 times)
  Normal   Scheduled               19s                default-scheduler        Successfully assigned default/gcs-example to kube2
  Normal   SuccessfulAttachVolume  18s                attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-a98c0de4cd5811e8"
  Normal   Pulling                 6s                 kubelet, kube2           pulling image "redis:latest"

mount info

kube1-0.glusterd2.gcs:pvc-a98c0de4cd5811e8 on /var/lib/kubelet/pods/a99009af-cd58-11e8-a385-52540065898d/volumes/kubernetes.io~csi/pvc-a98c0de4cd5811e8/mount type fuse.glusterfs (rw,relatime,user_id=0,group_id=0,default_permissions,allow_other,max_read=131072)

[Madhu-1]

Fixes: #26

[JohnStrunk]

I believe this Fixes #26 as opposed to 30

[Madhu-1]

@JohnStrunk yeah it fixes #26

[kshlm]

Is this all that is required to get GCS to work on 1.12? I needed a few more changes to the RBAC rules as well to get even the provisioner working.

[kshlm]

The registration socket is csi.sock as I see it. If that is the case, ADDRESS already provides the path, so we could use that. We do not need an additional volume for the registration socket, and have a separate env variable it.

[Madhu-1]

there is an issue opened in driver-registrar to combine both flags, once it's done we can reconsider this and use only one volume
current implementation is done as per CSI doc registrar-sidecar-configuratio

[kshlm]

Thanks for the doc link. Makes it a little more clear.

[kshlm]

If we really do need a separate variable for the registration socket, then shouldn't the value here be /registration/org.gluster.glusterfs/csi.sock?

[Madhu-1]

the driver-registrar expose a Unix domain socket to handle Kubelet Plugin Registration.
this socket MUST be surfaced on the host in the kubelet plugin registration directory (in addition to the CSI driver socket)

[kshlm]

Tested this out. Can confirm it works. Merging.