This repository has been archived by the owner on May 24, 2020. It is now read-only.
Add retries to deployment #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment tended to fail at 2 points: - When getting the gd2 peers - When adding devices It appears that these two failure points can be avoided by adding retries. This commit adds those retries. We retry getting peers by just removing the (repeat) fetch of the peers as the first instance had retries already. When adding devices, we simply try again if necessary during the loop. The fixes (particularly the second) are not ideal as I don't think we have a full understanding of the nature of the transient failures. Signed-off-by: John Strunk <jstrunk@redhat.com>
ghost
assigned 
kshlm
approved these changes
Nov 13, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment tended to fail at 2 points:
It appears that these two failure points can be avoided by adding
retries. This commit adds those retries. We retry getting peers by just
removing the (repeat) fetch of the peers as the first instance had
retries already. When adding devices, we simply try again if necessary
during the loop.
The fixes (particularly the second) are not ideal as I don't think we
have a full understanding of the nature of the transient failures.
I believe this will help #44 and #38, but I'm not closing them since it's unclear that this is the proper fix, particularly the retry during device add.