Fixes 1489439: Allows multiple disks per volume group. #450
Conversation
Signed-off-by: Devyani Kota <devyanikota@gmail.com>
gdeployfeatures/vg/vg.py
Outdated
| if section_dict['one-to-one'] == 'no': | ||
| vgnames *= len(pvnames) | ||
| else: | ||
| if section_dict['one-to-one'] == 'yes': |
There was a problem hiding this comment.
@devyanikota you can remove this one-to-one option altogether.
Because now we provide provision to add more than one pv to a vg by default.
So it is one-to-one if vgnames == pvnames (which we do anyway)
Else if vgnames == 1 and < pvnames we aggregrate.
So, one-to-one does not carry use except checking an extra condition. Can you review and remove it?
There was a problem hiding this comment.
@sac initially I thought we would be losing the feature of providing just one vgname and getting two vgs with their respective pvs, but there is no such feature in the manual creation either.
Now that I rethink, I think its best to remove this condition in order to avoid confusion, keeping in sync with the manual options.
Thank you.
Removing the feature where we provide a single common vg name RHS_vg, with two pvs vdb, vdc to create 2 vgs RHS_vg1 and RHS_vg2, since we already provide the provision of one-to-one mapping where vgnames = pvnames. Signed-off-by: Devyani Kota <devyanikota@gmail.com>
Fixes bug 1489439, allowing multiple disks per volume group.
One can use the following config file:
@sac Can you please review the patch. Thanks.