Create lvm exclude filter #107
Conversation
Post RHHI-V Deployment , certain tasks (that might involve brick creation, or Day2 operation like creation of new volume, expanding the cluster or volume,) require removal of existing LVM filter to avoid errors like " Device /dev/sdf excluded by a filter."
Post RHHI-V Deployment , certain tasks (that might involve brick creation, or Day2 operation like creation of new volume, expanding the cluster or volume,) require removal of existing LVM filter to avoid errors like " Device /dev/sdf excluded by a filter."
Create regenerate_new_lvm_filter_rules.yml
|
This PR contains two independent task
The reason why its created as two independent task, is that it can be further called or included in gluster-ansible tasks wherever applicable, so that code need not be repeated. |
Update main.yml
|
Requesting review :- @gobindadas @satheesaran |
| - name: Backup lvm.conf file | ||
| copy: | ||
| src: /etc/lvm/lvm.conf | ||
| dest: /backup |
There was a problem hiding this comment.
Will this directory be available? isn't it better to backup to same location with different name?
There was a problem hiding this comment.
This part of the code is not required. This information is added in the doc, as the user is prone to make such mistakes while editing manually, as this is covered in ansible, this code block is safe to be ignored
There was a problem hiding this comment.
@satheesaran , meaning backup is not necessary?
|
@pkesavap "Post RHHI-V Deployment " -> post or before the deployment? |
Moved the task to first and end of file
Removed backing up task
done, set to before |
|
@satheesaran @gobindadas have updated the discussed changes, |
|
Looks good |
roles/backend_setup/tasks/main.yml
Outdated
|
|
||
|
|
||
| - name: Exclue LVM Filter rules | ||
| import_tasks: lvm_exclude_filter.yml |
There was a problem hiding this comment.
This needs to be move to very first, otherwise blacklist mpath also will fail.
| copy: | ||
| src: /etc/lvm/lvm.conf | ||
| dest: /backup | ||
|
|
||
| - name: Remove the existing LVM filter |
There was a problem hiding this comment.
Will this fail if the pattern is not exist incase of deployment failure in middle before restore?
Should we need to add ignore_error=true ?
Before RHHI-V Deployment , certain tasks (that might involve brick creation, or Day2 operation like creation of new volume, expanding the cluster or volume,) require removal of existing LVM filter
to avoid errors like " Device /dev/sdf excluded by a filter."