Use ansible way to detect package existence, fixes gluster/gluster-ansible-infra#119 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hunter86bg <hunter86_bg@yahoo.com>
hunter86bg
changed the title
hunter86bg
changed the title
|
can you take a look ? |
amarts
approved these changes
May 31, 2021
mykaul
reviewed
May 31, 2021
| ansible.builtin.package_facts: | ||
| manager: auto | ||
|
|
||
| - name: Print the package facts |
There was a problem hiding this comment.
I'm not clear why you need to do this? (debug leftovers?)
There was a problem hiding this comment.
The debug will be visible only with '-v' or more , but won't be triggered with regular run.
That's due to 'verbosity: 1'.
There was a problem hiding this comment.
It shouldn't be a problem at all and it won't slow the code.
There was a problem hiding this comment.
And future debugging is easierwithout changing the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hunter86bg hunter86_bg@yahoo.com