Fix warnings #141
Closed
Fix warnings #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Note that this is based on top of #137 as there were same lines edited in these patches. If this gets merged, both the pull requests automatically get closed! |
|
I suggest to merge #137 first and then rebase this. |
Fixes: gluster#136 Signed-off-by: Amar Tumballi <amarts@redhat.com>
For global structure initialization, set only the fields which are non-zero. Fixes: gluster#140 Signed-off-by: Amar Tumballi <amarts@redhat.com>
lxbsz
reviewed
Oct 22, 2018
utils/utils.c
Outdated
| @@ -17,7 +17,7 @@ | |||
| # include "config.h" | |||
|
|
|||
|
|
|||
| struct gbConf gbConf = {LRU_COUNT_DEF, GB_LOG_INFO, GB_LOGDIR, '\0', '\0', '\0', '\0', '\0'}; | |||
| struct gbConf gbConf = {LRU_COUNT_DEF, GB_LOG_INFO, GB_LOGDIR, '\0', '\0', '\0', '\0', '\0', '\0', 0}; | |||
There was a problem hiding this comment.
Why not just init the default values as:
#define GLFS_HOST_DEF "localhost"
#define GLFS_PORT_DEF 24007
struct gbConf gbConf = {LRU_COUNT_DEF, GB_LOG_INFO, GB_LOGDIR, '\0', '\0', '\0', '\0', '\0', GLFS_HOST_DEF, GLFS_PORT_DEF};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #140